Skip to content

Use Option for author and message in rebase_commit #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2019
Merged

Use Option for author and message in rebase_commit #393

merged 2 commits into from
Jun 3, 2019

Conversation

akhilkpdasan
Copy link
Contributor

@alexcrichton
Copy link
Member

Thanks! I'm gonna hold off on this for now to batch up breaking changes, but will merge when another major version happens

@akhilkpdasan
Copy link
Contributor Author

It looks like signature is optional in rebase_finish as well https://libgit2.org/libgit2/#HEAD/group/rebase/git_rebase_finish

@alexcrichton
Copy link
Member

👍

@neithernut
Copy link

neithernut commented Jan 9, 2019 •
edited
Loading

FYI: regarding libgit2's git_rebase_commit() there are API changes/new capabilities being currently discussed (libgit2/libgit2#4913). These might affect this PR, eventually.

@alexcrichton
Copy link
Member

Ok we've got breaking changes on master now, so I"m going to merge! Thanks for the PR and sorry for the delay!

@alexcrichton alexcrichton merged commit 738e8e3 into rust-lang:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akhilkpdasan @alexcrichton @neithernut