Update documentation and CI for features #1182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joshtriplett
commented
Aug 22, 2025
joshtriplett
commented
- Test features in CI
- Add docs.rs metadata for features
- Add required features for examples
- README.md: Add feature documentation
weihanglo
approved these changes
Sep 13, 2025
ehuss
reviewed
Oct 6, 2025
Comment on lines
+52
to
+53
| [[examples]] | ||
| required-features = ["https", "ssh"] |
There was a problem hiding this comment.
This added invalid syntax to Cargo.toml. There is no such thing as examples.
warning: /Users/eric/Proj/rust/git2-rs/Cargo.toml: unused manifest key: examples
To set the required features, you have to list it for each individual example that needs it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.