libgit2-sys v0.12.15 fails to clone on Windows

[Alovchin91]

Hi,

I'm trying to use the latest git2-rs v0.13.13 that depends on libgit2-sys v0.12.15 and it fails to clone any repository with error 0x80000002 on Windows arm64.

It succeeds with v0.13.12 and strict dependency on libgit2-sys v0.12.14.

I believe there is a change in libgit2 that might have broken this functionality.

As I'm using Windows arm64 for development, my debugging capabilities are rather limited, but I will try to help solve this issue.

[Alovchin91]

I think I've found the culprit: libgit2/libgit2#5745

@ehuss @alexcrichton Would it make sense to meanwhile cherry-pick the merge commit which should fix zlib for Cargo and yank git2-rs v0.13.13 and libgit2-sys v0.12.15? I'm afraid that if people will start referencing it we'll see a bunch of programs that won't work on Windows arm64.

[lhchavez]

oh boy, i don't have a lot of windows or ARM experience (and i'm only learning Rust), so if a very minimal reproduction setup can be produced and machines with some sort of debugging are available, i can probably pitch in.

a priori: i know there are some subtle differences in how loads and stores behave in x86/arm, so that may help narrow the search space (which means that more locking may be needed)

[Alovchin91]

@lhchavez I'm afraid this is complicated since there are no CI/CD or cloud virtual machines with Windows arm64 (thanks MSFT). What you probably could do is use any arm64 machine (a Raspberry Pi or an Apple Silicon Mac are possibly the most common choices) to run Windows arm64 in Qemu.

Other than that, I can offer my Surface Pro X for remote debug connection, if this is even possible via Internet running test builds ¯\_(ツ)_/¯

EDIT:

Now that you've mentioned loads and stores I wonder if it also fails for arm64 Linux now 🤔

[lhchavez]

Now that you've mentioned loads and stores I wonder if it also fails for arm64 Linux now thinking

that last thing is what i hope, since it'll remove one unknown (Windows). i've been trying to get a RPi4 to boot with a 64-bit Ubuntu for the last two hours (and failing ^^;; probably old SD cards are to blame) to test this out since it's going to be the path of least resistance.

[Alovchin91]

I'm gonna try it on WSL 2 on that same Surface Pro X now.

[Alovchin91]

@lhchavez Yes, it also fails on WSL 2 for me: [1] 11546 bus error

[Alovchin91]

Hi @alexcrichton since #646 has been merged, would it be possible to yank git2-rs v0.13.13 and libgit2-sys v0.12.15 and release new versions? As mentioned in libgit2/libgit2#5745 , it's not just about Windows arm64, but other systems are also affected, including Linux arm64 which AFAIK is Tier 1 platform. The longer those versions stay in the wild, the more software might become broken. Thanks!

[ehuss]

@Alovchin91 I'll publish a new version soon.

[alexcrichton]

I have had a moment now and went ahead and published. I'll be happy to yank the previous one if it ends up continuing to cause issues as well!