is_path_ignored not working on windows

[Eh2406]

steps to repro:
start a new cargo project C:\> cargo new git2-test then
check that .gitignore includes /target
add git2 = "*" to Cargo.toml and the following to main.rs

extern crate git2;

fn main() {
    let p_exe = std::env::current_exe().unwrap();
    println!("./target/debug == {:?}", p_exe.display());
    let repo = git2::Repository::discover(&p_exe).unwrap();
    println!("./.git == {:?}", repo.path().display());
    let ignored = repo.is_path_ignored(&p_exe).unwrap();
    println!("true == {:?}", ignored);
}

(or unzip the file git2-test.zip) and do cargo run.

output is:

C:\git2-test>cargo run
   Compiling git2-test v0.1.0 (file:///C:/git2-test)
    Finished dev [unoptimized + debuginfo] target(s) in 1.78s
     Running `target\debug\git2-test.exe`
./target/debug == "C:\\git2-test\\target\\debug\\git2-test.exe"
./.git == "C:/git2-test/.git/"
true == false

I expected the last line to be true == true

tested on windows 10 locally, reduced from appveyor testing rust-lang/cargo#5733

[alexcrichton]

This is likely either a bug in libgit2 or a facet that we need to work around unfortunately :(

[alexcrichton]

Thanks for diagnosing this though!

[Eh2406]

I refined it as far as I can. I don't have the C knowledge to reported up stream.

If you have a suggestion for a workaround, I'm all ears.

[alexcrichton]

We may need to to_string it and convert \ to / to maybe work, but that's the only workaruond I'd posisbly know what to do :(

[Eh2406]

That seems to work locally. Odd that discover did not need that conversion. What is the most reliable way to convert? to_string_lossy?

[Eh2406]

Also should we Implement that work around here or in each user of this crates?

[alexcrichton]

Yeah something like to_string_lossy would be reasonable, and I'd be fine with a fix in this crate itself

[dwijnand]

The other workaround, probably not worth considering but maybe worth studying, is https://github.com/BurntSushi/ripgrep/tree/master/ignore.