-
Notifications
You must be signed in to change notification settings - Fork 669
tests: restore disabled tests and benches for BiLock #2715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b802888 to
0007315
Compare
|
Miri complains: Will it be desirable to go ahead with https://crates.io/crates/sptr as suggested in the error message? |
df79882 to
0a38a75
Compare
|
Thanks @taiki-e! I've rebased it on top of current master. CI / cargo +beta build (pull_request) failed once with: |
taiki-e
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
0a38a75 to
ef9494b
Compare
ef9494b to
bbf8b0c
Compare
|
Thanks for review! Fixed the comments, please take another look |
Hi! I was curious about BiLock internals (came there from its usage in split) so the easiest way to play with something is to poke into corresponding tests. Found out that tests and benchmarks for BiLock are disabled so I went ahead with reviving them to be up to date with current landscape.
Thank you your great work on the library!