-
Notifications
You must be signed in to change notification settings - Fork 668
add FuturesUnordered::into_iter, make iter_pin_ref public #2423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add FuturesUnordered::into_iter, make iter_pin_ref public #2423
Conversation
|
I think it's fine to make If we remove |
26b7617 to
0aadc4b
Compare
Co-authored-by: Taiki Endo <te316e89@gmail.com>
taiki-e
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
IterPinRef.FuturesUnordered::iter_pin_refis private for some reason, so it is impossible to create aIterPinRef. Of course, this means that no one used it. I don't see how iterating over aPin<&Fut>is useful anyways. This is still a breaking change however, because the struct was public, albeit impossible to construct.IntoIteratorforFuturesUnordered,&FuturesUnordered, and&mut FuturesUnordered, and add anIntoIteriterator struct for the first.Resolves #1795.