Skip to content

perf: Avoid an Option in the Map* futures #2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2021
Merged

Conversation

Marwes
Copy link
Contributor

@Marwes Marwes commented Jan 7, 2021

Forces another unsafe block but shrinks the generated future a bit

@taiki-e taiki-e added A-future Area: futures::future S-blocked Status: Blocked on something else and removed S-blocked Status: Blocked on something else labels Jan 8, 2021
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@taiki-e taiki-e merged commit 1db2b4e into rust-lang:master Jan 11, 2021
@Marwes Marwes deleted the map branch January 11, 2021 12:15
exrook pushed a commit to exrook/futures-rs that referenced this pull request Apr 5, 2021
* perf: Avoid an Option in the `Map*` futures

* refactor: Rewrite UnfoldState with project_replace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-future Area: futures::future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants