Skip to content

Stage 0.3.0-alpha.7 release #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Conversation

cramertj
Copy link
Member

@cramertj cramertj commented Oct 2, 2018

No description provided.

@Nemo157
Copy link
Member

Nemo157 commented Oct 2, 2018

I believe there's some doc attributes that need updating for every version as well?

EDIT: e.g. here: https://github.com/rust-lang-nursery/futures-rs/blob/7306d7b7cf43faab24d031abdb7743610dbb2eb2/futures-core/src/lib.rs#L11

futures-core-preview = { path = "../futures-core", version = "0.3.0-alpha.7", default-features = false }
futures-channel-preview = { path = "../futures-channel", version = "0.3.0-alpha.7", default-features = false }
futures-io-preview = { path = "../futures-io", version = "0.3.0-alpha.7", default-features = false }
futures-sink-preview = { path = "../futures-sink", version = "0.3.0-alpha.7", default-features = false}
either = { version = "1.4", default-features = false }
slab = { version = "0.4", optional = true }
futures = { version = "0.1", optional = true }
tokio-executor = { version = "0.1.2", optional = true }
pin-utils = "0.1.0-alpha.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version doesn't build on latest nightly, should be bumped to 0.1.0-alpha.3 to force a Cargo.lock update. (I haven't checked whether any other crates directly depend on it).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #1274 to update this and re-enable the minimal versions testing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@cramertj
Copy link
Member Author

cramertj commented Oct 2, 2018

Updated.

@aturon
Copy link
Member

aturon commented Oct 2, 2018

LGTM, modulo travis.

@JesseWright
Copy link

I might have missed something, but I think the compat feature is broken: compat03to01.rs still includes PinMut instead of Pin after #1268. Should that go out with alpha 7?

@cramertj
Copy link
Member Author

cramertj commented Oct 2, 2018

@JesseWright Huh, weird-- I was definitely building with it working earlier, but perhaps it got caught twice by one of my regexes. Thanks for pointing it out!

@cramertj
Copy link
Member Author

cramertj commented Oct 2, 2018

@aturon travis has been angry because of rust-lang/rust#43466 (comment)

@cramertj cramertj merged commit 99795ef into rust-lang:master Oct 2, 2018
@cramertj cramertj deleted the 0.3.0-alpha.7 branch October 2, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants