Skip to content

Conversation

tshepang
Copy link
Member

No description provided.

@traviscross
Copy link
Contributor

traviscross commented Sep 25, 2025

@PLeVasseur, @nikomatsakis, any thoughts?

@tshepang tshepang force-pushed the tshepang/document-1.89 branch from 95d0b7b to 524cb77 Compare September 29, 2025 19:59
tshepang and others added 5 commits September 29, 2025 22:01
Co-authored-by: Travis Cross <tc@traviscross.com>
Can be used outside of functions:

  const X: [u8; 1] = {
      let x: [u8; _] = [0; _];
      x
  };
@tshepang tshepang force-pushed the tshepang/document-1.89 branch from 524cb77 to 318a2f8 Compare September 29, 2025 20:01
@tshepang
Copy link
Member Author

reviews addressed...

@tshepang
Copy link
Member Author

tshepang commented Oct 2, 2025

reviews addressed...

@tshepang
Copy link
Member Author

tshepang commented Oct 2, 2025

also made an attempt at a definition

Comment on lines 644 to 647
* :dp:`fls_eeaJtK4w5gVK`
The :t:`[argument operand]s` of an extending :t:`call expression`
of a :t:`tuple struct` or a :t:`tuple enum variant`.

Copy link
Contributor

@traviscross traviscross Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be correct in the Reference, but I don't think this verbiage matches the style and structure here. The FLS doesn't say "the X of an extending Y expression". It says "the X of an Y expression that is an extending expression". This makes sense in the context of how the FLS is tying things back to the defined term "extending expression".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, do you think that "call expression of a tuple struct" is a clear enough way to describe a call expression where the call operand corresponds to the value namespace constructor for a tuple struct? The "of" there reads a bit odd to me. The glossary entry for "tuple struct call expression" defines it in terms of a "call expression where the call operand resolves to a tuple struct", and something like that sounds much clearer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tshepang tshepang force-pushed the tshepang/document-1.89 branch from 07e74e4 to 27d3a35 Compare October 6, 2025 03:18
@traviscross
Copy link
Contributor

Looks good. Thanks @tshepang.

@traviscross traviscross added this pull request to the merge queue Oct 6, 2025
@traviscross traviscross removed this pull request from the merge queue due to a manual request Oct 6, 2025
@traviscross traviscross added this pull request to the merge queue Oct 6, 2025
Merged via the queue into rust-lang:main with commit ffab2d2 Oct 6, 2025
3 checks passed
@tshepang tshepang deleted the tshepang/document-1.89 branch October 6, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants