-
Notifications
You must be signed in to change notification settings - Fork 38
document Rust 1.89 #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document Rust 1.89 #579
Conversation
@PLeVasseur, @nikomatsakis, any thoughts? |
95d0b7b
to
524cb77
Compare
Co-authored-by: Travis Cross <tc@traviscross.com>
Can be used outside of functions: const X: [u8; 1] = { let x: [u8; _] = [0; _]; x };
524cb77
to
318a2f8
Compare
reviews addressed... |
reviews addressed... |
also made an attempt at a definition |
* :dp:`fls_eeaJtK4w5gVK` | ||
The :t:`[argument operand]s` of an extending :t:`call expression` | ||
of a :t:`tuple struct` or a :t:`tuple enum variant`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be correct in the Reference, but I don't think this verbiage matches the style and structure here. The FLS doesn't say "the X of an extending Y expression". It says "the X of an Y expression that is an extending expression". This makes sense in the context of how the FLS is tying things back to the defined term "extending expression".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do you think that "call expression of a tuple struct" is a clear enough way to describe a call expression where the call operand corresponds to the value namespace constructor for a tuple struct? The "of" there reads a bit odd to me. The glossary entry for "tuple struct call expression" defines it in terms of a "call expression where the call operand resolves to a tuple struct", and something like that sounds much clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
07e74e4
to
27d3a35
Compare
Looks good. Thanks @tshepang. |
No description provided.