Skip to content

chore: update deps #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025
Merged

chore: update deps #485

merged 1 commit into from
Apr 27, 2025

Conversation

CosminPerRam
Copy link
Contributor

No major version changes, mostly patches including fixes and small performance improvements.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, a good catch!

We might want to consider to use dependabot for this - there is probably no good reason to not keep up with the latest versions.

@Byron Byron merged commit 306e909 into rust-lang:main Apr 27, 2025
14 checks passed
@CosminPerRam
Copy link
Contributor Author

For sure, will make a PR for this soon.

@jongiddy
Copy link
Contributor

For a library crate, isn't the effect of these version updates simply to reduce the options available to dependent crates?

i.e. previously flate2 was compatible with any version of libz-sys >= 1.1.20, but now it requires at least 1.1.22. If, for any reason, a crate needs to keep libz-sys at 1.1.20, it now has a conflict.

I tend to update crate versions only when there is a security or bug fix reason to do so.

@Byron
Copy link
Member

Byron commented Apr 28, 2025

Thanks @jongiddy for chiming in and making that point.

To hammer home the "upgrades only when there is a need" idea, I think we'd also want to have a cargo audit job, probably as cron job, to get a heads up early.
There could also be a section in the README related to manifest update policies just to make it a little more official and accessible.

@CosminPerRam CosminPerRam mentioned this pull request Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants