Rust adbench #1
Merged
Rust adbench #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lorenz Schmidt <bytesnake@mailbox.org> Co-authored-by: Jed Brown <jed@jedbrown.org> Co-authored-by: William Moses <gh@wsmoses.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to maintain a Rust version of ADBench, and getting it merged upstream proved to be challenging for a few months, so merging it here for now. Once we have more autodiff code in the rustc CI, we should consider adding these benchmarks too, in one way or another.
Currently, lstm is failing due to an Enzyme bug, but it worked with a sufficiently old rust+llvm+enzyme version, ~6 months ago. The bug was minimized and reported here: EnzymeAD#2270
I assume we want to track differences from upstream to potentially drop the if upstream decides to merge our Rust changes. So I'm merging this as a PR and not just pushing it to main.