Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section for the never type change in e2024 #310

Merged
merged 8 commits into from
Jun 30, 2024

Commits on Jun 28, 2024

  1. Configuration menu
    Copy the full SHA
    67a5615 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    509ac7d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7d227ca View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Configuration menu
    Copy the full SHA
    f51cd80 View commit details
    Browse the repository at this point in the history
  2. Align page title with summary title

    Aside from aligning it with the summary entry, another reason to say
    "never type fallback change" is that if we were to say "to itself", we
    should say "never type fall back to itself", grammatically.  But it
    seems better here to just use the noun form, so we'll be consistent
    with that.
    traviscross committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    6a2e762 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8567b15 View commit details
    Browse the repository at this point in the history
  4. Unwrap lines

    The line wrapping was a bit inconsistent.  Let's just unwrap all the
    lines on this page.
    traviscross committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    2eea6dc View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Make an editing pass and make all tests work

    On the page for the never type fallback change, we've made a general
    copyediting pass.  As part of this, we've also fixed all of the tests
    such that they are checked and not simply ignored.
    
    Strangely, some of the longer explanations that had been added to the
    ignored tests were causing weird formatting issues in the rendered
    output.  The example blocks weren't taking up the full width, and text
    was flowing around them.  Making the tests work instead, and removing
    these explanations, resolves this issue.
    traviscross committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    42b054d View commit details
    Browse the repository at this point in the history