-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a section for the never type change in e2024 #310
Merged
traviscross
merged 8 commits into
rust-lang:master
from
WaffleLapkin:never-type-fallback
Jun 30, 2024
Merged
Add a section for the never type change in e2024 #310
traviscross
merged 8 commits into
rust-lang:master
from
WaffleLapkin:never-type-fallback
Jun 30, 2024
Commits on Jun 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 67a5615 - Browse repository at this point
Copy the full SHA 67a5615View commit details -
Configuration menu - View commit details
-
Copy full SHA for 509ac7d - Browse repository at this point
Copy the full SHA 509ac7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d227ca - Browse repository at this point
Copy the full SHA 7d227caView commit details
Commits on Jun 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f51cd80 - Browse repository at this point
Copy the full SHA f51cd80View commit details -
Align page title with summary title
Aside from aligning it with the summary entry, another reason to say "never type fallback change" is that if we were to say "to itself", we should say "never type fall back to itself", grammatically. But it seems better here to just use the noun form, so we'll be consistent with that.
Configuration menu - View commit details
-
Copy full SHA for 6a2e762 - Browse repository at this point
Copy the full SHA 6a2e762View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8567b15 - Browse repository at this point
Copy the full SHA 8567b15View commit details -
The line wrapping was a bit inconsistent. Let's just unwrap all the lines on this page.
Configuration menu - View commit details
-
Copy full SHA for 2eea6dc - Browse repository at this point
Copy the full SHA 2eea6dcView commit details
Commits on Jun 30, 2024
-
Make an editing pass and make all tests work
On the page for the never type fallback change, we've made a general copyediting pass. As part of this, we've also fixed all of the tests such that they are checked and not simply ignored. Strangely, some of the longer explanations that had been added to the ignored tests were causing weird formatting issues in the rendered output. The example blocks weren't taking up the full width, and text was flowing around them. Making the tests work instead, and removing these explanations, resolves this issue.
Configuration menu - View commit details
-
Copy full SHA for 42b054d - Browse repository at this point
Copy the full SHA 42b054dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.