Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't build default target twice #534

Merged
merged 9 commits into from
Jan 7, 2020
Merged

Don't build default target twice #534

merged 9 commits into from
Jan 7, 2020

Commits on Jan 7, 2020

  1. update documentation on package metadata

    @QuietMisdreavus @jyn514
    QuietMisdreavus authored and jyn514 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    c972937 View commit details
    Browse the repository at this point in the history

  2. don't build default target twice

    @jyn514
    jyn514 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    ac34f96 View commit details
    Browse the repository at this point in the history

  3. Allow navigating back to default target 

    The code as of the previous commit would let you navigate away from the
default, but not navigate back. This adds the default target to
`successful_targets` to add a link to the dropdown in 'Platform'.

After adding that, the link would give a 404
(because we treat paths literally when sending them to the database),
so the metadata for every crate now has to include the default target,
which allows redirecting to /:crate/:version/:module/ when visiting
/:crate/:version/:module/:default-target
    @jyn514
    jyn514 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    675b96a View commit details
    Browse the repository at this point in the history

  4. remove --target by default 

    this required a bit of a rearchitecture
    @jyn514
    jyn514 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    fa14994 View commit details
    Browse the repository at this point in the history

  5. use const instead of static 

    also uses a constant instead of hardcoding the default target
    @jyn514
    jyn514 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    1dc6c87 View commit details
    Browse the repository at this point in the history

  6. allow different default targets

    @jyn514
    jyn514 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    65d0096 View commit details
    Browse the repository at this point in the history

  7. fix bad merge

    @jyn514
    jyn514 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    ae14be3 View commit details
    Browse the repository at this point in the history

  8. Don't move every build into target/doc 

    Only the default build should be in target/doc.
    @jyn514
    jyn514 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    7dd79c5 View commit details
    Browse the repository at this point in the history

  9. default: none -> default: []

    @jyn514
    jyn514 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    e2d5a0f View commit details
    Browse the repository at this point in the history