Skip to content

ci: don't override rust toolchain, so rust-toolchain.toml is actually used #2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

syphar
Copy link
Member

@syphar syphar commented Jul 4, 2025

seeing #2852 I actually realized that our rust-toolchain.toml was actually never used in CI.

This changes here.

@syphar syphar requested a review from a team as a code owner July 4, 2025 06:45
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jul 4, 2025
@GuillaumeGomez
Copy link
Member

Do we ever actually make use locally of that rust-toolchain.toml? Isn't "we support latest stable" a better approach?

@syphar
Copy link
Member Author

syphar commented Jul 4, 2025

I thought it's automatically used locally?

The idea of a toolchain lock would be that it doesn't randomly break clippy ci any more?

@GuillaumeGomez
Copy link
Member

True. Merging then, thanks!

@GuillaumeGomez GuillaumeGomez merged commit 054b69f into rust-lang:master Jul 4, 2025
9 checks passed
@GuillaumeGomez GuillaumeGomez deleted the toolchain-toml branch July 4, 2025 10:04
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants