Build & upload rustdoc json output next to other docs #2827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
json
branch
2 times, most recently
from
79e5717 to
42eb6c7
Compare
syphar
commented
May 21, 2025
syphar
force-pushed
the
json
branch
2 times, most recently
from
eb1cb21 to
f193909
Compare
syphar
changed the title
syphar
changed the title
|
Should we add a link to download the JSON? |
See above
I feel like I want to have the builds running first and then do the redirect handlers. |
Ah sorry, only read the code and didn't read the first comment. ^^' |
GuillaumeGomez
approved these changes
May 22, 2025
|
Looks all good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #1285
This first will just start building the json & put the files into the bucket & the logs into our log-storage.
The handlers to access the JSON will follow in another PR.
I think the whole builder needs a refactor so we don't need these huge methods any more, but I want to do that separately.