Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditionally set build.rustdocflags #2484

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Apr 6, 2024

As of #2390, all_rustdoc_args cannot ever be empty.

let mut all_rustdoc_args = vec!["--cfg".into(), "docsrs".into()];

@dtolnay dtolnay requested a review from a team as a code owner April 6, 2024 20:37
@github-actions github-actions bot added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Apr 6, 2024
@GuillaumeGomez
Copy link
Member

Interesting unrelated failure in CI...

@Nemo157
Copy link
Member

Nemo157 commented Apr 6, 2024

#2487 fixes the CI failure

@syphar syphar merged commit c838c47 into rust-lang:master Apr 7, 2024
10 of 11 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Apr 7, 2024
@dtolnay dtolnay deleted the alwaysdocflags branch April 7, 2024 04:30
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants