Refactor static file handling #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved the static files out of templates/ and src/ (both as static files that got included in the build, and as static strings in the source) into the static/ directory * Copied the static/ directory into the docker image as static/ * Removed the `staticfile` handler serving from $CRATESFYI_PREFIX/public_html/ since those files are now in static/
jyn514
added
A-backend
jyn514
reviewed
Oct 13, 2020
src/web/routes.rs
Outdated
| "/opensearch.xml", | ||
| PermanentRedirect("/-/static/opensearch.xml"), | ||
| ); | ||
| routes.static_resource("/sitemap.xml", PermanentRedirect("/-/sitemap.xml")); |
There was a problem hiding this comment.
The sitemap has to live at the top level:
A sitemap can be posted anywhere on your site, but a sitemap affects only descendants of the parent directory. Therefore, a sitemap posted at the site root can affect all files on the site, which is where we recommend posting your sitemaps.
There was a problem hiding this comment.
Ok, that was one I was wondering about, I'll change this back and put in a comment.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the static files out of templates/ and src/ (both as static files that got included in the build, and as static strings in the source) into the static/ directory
Copied the static/ directory into the docker image as static/
Removed the
staticfilehandler serving from $CRATESFYI_PREFIX/public_html/ since those files are now in static/Add metrics tracking DatabaseFileHandler usage
Fixes #55