Skip to content

jobs/send_publish_notifications: Add logging calls #9357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Aug 29, 2024

This can be used to give us a bit more insight into how many emails we are sending out and whether any of them are failing to get sent.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Aug 29, 2024
@Turbo87 Turbo87 force-pushed the publish-notification-logging branch from f4c1a45 to 408867d Compare August 29, 2024 14:02
@Turbo87 Turbo87 force-pushed the publish-notification-logging branch from 408867d to bc57341 Compare August 29, 2024 14:09
@Turbo87 Turbo87 enabled auto-merge (squash) August 29, 2024 14:12
@Turbo87 Turbo87 merged commit 72f9568 into rust-lang:main Aug 29, 2024
8 checks passed
@Turbo87 Turbo87 deleted the publish-notification-logging branch August 29, 2024 15:13
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (035cae8) to head (bc57341).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/worker/jobs/send_publish_notifications.rs 76.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9357      +/-   ##
==========================================
- Coverage   89.22%   89.20%   -0.02%     
==========================================
  Files         283      283              
  Lines       29073    29091      +18     
==========================================
+ Hits        25939    25950      +11     
- Misses       3134     3141       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant