Skip to content

storage: Adjust content types for version downloads archive files #9295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Aug 20, 2024

Otherwise the index.html is served with Content-Type: binary/octet-stream and the browser shows a download dialog...

@Turbo87 Turbo87 added C-bug 🐞 Category: unintended, undesired behavior A-backend ⚙️ labels Aug 20, 2024
@Turbo87 Turbo87 enabled auto-merge (squash) August 20, 2024 12:55
@Turbo87 Turbo87 merged commit 40c72a4 into rust-lang:main Aug 20, 2024
8 checks passed
@Turbo87 Turbo87 deleted the storage-content-types branch August 20, 2024 13:08
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.14%. Comparing base (403e7a2) to head (b2cbfec).
Report is 1 commits behind head on main.

Files Patch % Lines
src/storage.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9295      +/-   ##
==========================================
- Coverage   89.15%   89.14%   -0.02%     
==========================================
  Files         283      283              
  Lines       28817    28821       +4     
==========================================
- Hits        25693    25692       -1     
- Misses       3124     3129       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant