Port crate/versions over to use Diesel
#755
Conversation
src/krate.rs
Outdated
| let conn = req.db_conn()?; | ||
| let krate = Crate::by_name(crate_name).first::<Crate>(&*conn)?; | ||
| let mut versions = Version::belonging_to(&krate).load::<Version>(&*conn)?; | ||
| versions.sort_by(|a, b| b.num.cmp(&a.num)); |
There was a problem hiding this comment.
This sorting is getting duplicated in multiple places-- do you think we could make a method that uses diesel that behaves like krate.versions() does now, that would always sort the versions? Or is there some reason why we wouldn't want that?
There was a problem hiding this comment.
Normally we'd just do the sort in SQL, it sucks that we can't here. There's no specific reason why we can't have krate.versions, I mostly just wanted to move more behavior off that struct since it's already doing so much. Code that relies on the fact that versions are sorted should make it clear that they care about that fact IMO. I liked the solution in the build info PR
There was a problem hiding this comment.
@carols10cents Did you want me to copy the method from that PR? Or can refactoring that wait until both have been merged?
sgrif
force-pushed
the
sg-port-crate-versions
branch
2 times, most recently
from
58b3ec8 to
439aa99
Compare
sgrif
force-pushed
the
sg-port-crate-versions
branch
from
439aa99 to
d4a8337
Compare
No description provided.