Display the version badge on crate list pages #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the plain-text version number. This has the advantage of quickly showing pre-1.0 (orange) vs. post-1.0 (blue) when scanning down a list of crates. Since people might want to copy the version number of a crate from the crate list page, I've changed the alt text of the image to just be the version number that used to appear here, so that you can highlight the image and copy the version number.
carols10cents
added a commit
to integer32llc/crates.io
that referenced
this pull request
Dec 3, 2016
I broke this in rust-lang#481 :(
|
Now that this is live; this is not a better UI: the version number text is small and the badge is completely out of place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the plain-text version number.
This has the advantage of quickly showing pre-1.0 (orange) vs. post-1.0
(blue) when scanning down a list of crates.
Since people might want to copy the version number of a crate from the
crate list page, I've changed the alt text of the image to just be the
version number that used to appear here, so that you can highlight the
image and copy the version number.
Screenshot: