Skip to content

Implement new /settings route #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Implement new /settings route #4309

merged 3 commits into from
Dec 21, 2021

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 21, 2021

This is basically similar to the /me route, but split into multiple subroutes to make the settings more scaleable.

Bildschirmfoto 2021-12-21 um 13 54 58

Bildschirmfoto 2021-12-21 um 13 55 14

Only `me.index` is migrated to `settings.index`, the other nested `me` routes still keep their old paths for now.
@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Dec 21, 2021
@Turbo87 Turbo87 requested review from locks and pichfl December 21, 2021 17:40
@locks
Copy link
Contributor

locks commented Dec 21, 2021

I think this is much cleaner and leaves room for growth!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 21, 2021

📌 Commit 36cd32b has been approved by locks

@bors
Copy link
Contributor

bors commented Dec 21, 2021

⌛ Testing commit 36cd32b with merge 889c86d...

@bors
Copy link
Contributor

bors commented Dec 21, 2021

☀️ Test successful - checks-actions
Approved by: locks
Pushing 889c86d to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants