Ensure the release succeeds when the primary database is read-only #3562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtgeibel
commented
Apr 26, 2021
|
Hmm, I would probably change this to straight up skip everything if we're in read-only mode. |
3 tasks
If the primary is in read-only mode then the leader database in `DATABASE_URL` may be unavailable. To avoid blocking configuration changes, the command exits immediately claiming success.
jtgeibel
force-pushed
the
fail-migrations-in-read-only
branch
from
c50a4a2 to
4d269b5
Compare
jtgeibel
changed the title
Yes, that seems like the correct interpretation. I've updated the PR to return success in this situation, and have added some TODO notes regarding future improvements. |
|
@bors r+ Thanks! Could you open issues to track the TODOs you added? |
|
📌 Commit 4d269b5 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the primary is in read-only mode then the leader database in
DATABASE_URLmay be unavailable. To avoid blocking configurationchanges, the command exits immediately claiming success.
r? @pietroalbini