Create crates-admin migrate to sync categories and migrate the db
#3556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wouldn't it be better to make this a subcommand of the crates-admin binary to avoid the additional linking step? |
pietroalbini
force-pushed
the
bin-migrate
branch
from
77eaa7f to
9132f1e
Compare
pietroalbini
changed the title
migrate binary to sync categories and migrate the dbcrates-admin migrate to sync categories and migrate the db
The new command will be used in production to run migrations instead of installing the Diesel CLI and running migrations through it. In addition to that, synchronizing categories has been moved to the `crates-admin migrate` command instead of being executed every time the application starts. The main advantage of this is, booting the server will not *require* a fully working database connection anymore. A connection is still needed, but this removes all the blockers for removing that limit.
pietroalbini
force-pushed
the
bin-migrate
branch
from
9132f1e to
1929eea
Compare
|
Updated the PR to use a |
|
LGTM too! @bors r=Turbo87 |
|
📌 Commit 1929eea has been approved by |
|
☀️ Test successful - checks-actions |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new command will be used in production to run migrations instead of installing the Diesel CLI and running migrations through it. In addition to that, synchronizing categories has been moved to the
crates-admin migratecommand instead of being executed every time the application starts.The main advantage of this is, booting the server will not require a fully working database connection anymore. A connection is still needed, but this removes all the blockers for removing that limit.
r? @jtgeibel
Part of #3541