Skip to content

Move away from deprecated team membership API #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

thiagoarrais
Copy link
Contributor

@thiagoarrais thiagoarrais commented Sep 21, 2020

Endpoint /teams/:team_id/memberships/:user_name is fading away as per https://developer.github.com/changes/2020-01-21-moving-the-team-api-endpoints/

This moves away from that in favor of the new endpoint: /organizations/:org_id/team/:team_id/memberships/:username.

Fixes #2619

@rust-highfive
Copy link

r? @jtgeibel

(rust_highfive has picked a reviewer for you, use r? to override)

@thiagoarrais
Copy link
Contributor Author

thiagoarrais commented Sep 21, 2020

Created as draft to prevent acidental merging since it depends on backfilling the database with the missing organization IDs.

See #2796

@jtgeibel: any comments here?

@thiagoarrais thiagoarrais force-pushed the use-orgid-for-membership-check branch from 4833e5d to c862449 Compare October 29, 2020 17:39
@thiagoarrais thiagoarrais force-pushed the use-orgid-for-membership-check branch from c862449 to 158daea Compare October 29, 2020 17:44
@thiagoarrais thiagoarrais marked this pull request as ready for review October 29, 2020 17:46
@thiagoarrais
Copy link
Contributor Author

Rebased to latest master and removed the (now obsolete) org id backfilling binary. Let me know if you need anything else.

@jtgeibel
Copy link
Member

This is now deployed to staging. We'll need a team that we can add to a crate, and a user on that team that can test publishing a new version.

If you want to publish a crate to staging and add the team github:conduit-rust:test then I can try publishing. I've also added this to tomorrow's weekly meeting as we might be able to coordinate something there as well.

@thiagoarrais
Copy link
Contributor Author

I've created the crate but can't add the team because "could not find the github team conduit-rust/test"

@jtgeibel
Copy link
Member

Oops, membership on that team was set to private, so you need to be a member to add the team. I've made that test team public and sent you an invite so you can join if that doesn't work for some reason.

@thiagoarrais
Copy link
Contributor Author

Ok. I've added the team to the crate issue-2619 now.

@jtgeibel
Copy link
Member

Alright, I've been able to publish a 0.1.1 as a team member on staging. LGTM! Thank you so much @thiagoarrais for the series of PRs to get this fixed!

I plan to deploy to production tomorrow.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 11, 2020

📌 Commit 158daea has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Nov 11, 2020

⌛ Testing commit 158daea with merge c2419a1...

@bors
Copy link
Contributor

bors commented Nov 11, 2020

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing c2419a1 to master...

@bors bors merged commit c2419a1 into rust-lang:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation of GitHub teams API URL format that we use
4 participants