-
Notifications
You must be signed in to change notification settings - Fork 650
Move away from deprecated team membership API #2810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from deprecated team membership API #2810
Conversation
r? @jtgeibel (rust_highfive has picked a reviewer for you, use r? to override) |
Endpoint `/teams/:team_id/memberships/:user_name` is fading away as per https://developer.github.com/changes/2020-01-21-moving-the-team-api-endpoints/
4833e5d
to
c862449
Compare
c862449
to
158daea
Compare
Rebased to latest master and removed the (now obsolete) org id backfilling binary. Let me know if you need anything else. |
This is now deployed to staging. We'll need a team that we can add to a crate, and a user on that team that can test publishing a new version. If you want to publish a crate to staging and add the team |
I've created the crate but can't add the team because "could not find the github team conduit-rust/test" |
Oops, membership on that team was set to private, so you need to be a member to add the team. I've made that test team public and sent you an invite so you can join if that doesn't work for some reason. |
Ok. I've added the team to the crate issue-2619 now. |
Alright, I've been able to publish a 0.1.1 as a team member on staging. LGTM! Thank you so much @thiagoarrais for the series of PRs to get this fixed! I plan to deploy to production tomorrow. @bors r+ |
📌 Commit 158daea has been approved by |
☀️ Test successful - checks-travis |
Endpoint
/teams/:team_id/memberships/:user_name
is fading away as per https://developer.github.com/changes/2020-01-21-moving-the-team-api-endpoints/This moves away from that in favor of the new endpoint:
/organizations/:org_id/team/:team_id/memberships/:username
.Fixes #2619