Skip to content

Add tests for the API token list #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2020
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Mar 5, 2020

This adds a few basic application test for the API token list on the /me route. This should help in preventing regressions like mentioned in #2211.

r? @jtgeibel

Copy link
Member

@jtgeibel jtgeibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent! Once you fix the timezone shenanigans you mentioned, I'll r+.

@jtgeibel
Copy link
Member

jtgeibel commented Mar 6, 2020

I'll r+.

Oops, I meant feel free to bors r=me.

@Turbo87
Copy link
Member Author

Turbo87 commented Mar 6, 2020

@bors r=@jtgeibel

@bors
Copy link
Contributor

bors commented Mar 6, 2020

📌 Commit 736f5e9 has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Mar 6, 2020

⌛ Testing commit 736f5e9 with merge f05a6fc...

@bors
Copy link
Contributor

bors commented Mar 6, 2020

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing f05a6fc to master...

@bors bors merged commit f05a6fc into rust-lang:master Mar 6, 2020
bors added a commit that referenced this pull request Mar 20, 2020
tests/api-token: Add Percy snapshot

This PR improves upon #2251 by adding a Percy snapshot to the API tokens test. This will ensure that the styling of the `/me` route will not get broken in the future.
@Turbo87 Turbo87 deleted the api-token-test branch March 20, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants