Update swirl #1894
Closed
Update swirl #1894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest revisions to swirl include:
- Concrete error types everywhere instead of `Box<dyn Error>`, which
simplifies conversion for us.
- Automatic handling of connection pool configuration
- Swirl can now just take a DB url, and defaults to a connection pool
with 2x the thread count connections, which is what we want
- Jobs can take a connection as an argument, meaning we don't need to
carry around a pool manually in the environment
- Updated dependencies
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Note: This is still pointing at a local path instead of git, sgrif/swirl#20 and sgrif/swirl#21 need review so they can be merged at which point I will point this at the merge commit on master and take it out of draft mode |
|
(There's no reason this PR can't be reviewed, it just can't be merged) |
|
I haven't looked at any of the upstream changes, but as a consumer of the API this PR looks good so far. |
|
Closing in favor of #2269 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest revisions to swirl include:
Box<dyn Error>, whichsimplifies conversion for us.
with 2x the thread count connections, which is what we want
carry around a pool manually in the environment