Turn off debug symbols #1662
Merged
Turn off debug symbols #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like hyper may have fixed our memory issue after all. I'd still like to spend some time looking at heap dumps because I still think our memory usage is higher than reasonable, but it's low priority and not something I'm going to do this week, and leaving debug info on makes our binaries *huge*
|
@bors r+ |
|
📌 Commit bc91a96 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 12, 2019
Turn off debug symbols It looks like hyper may have fixed our memory issue after all. I'd still like to spend some time looking at heap dumps because I still think our memory usage is higher than reasonable, but it's low priority and not something I'm going to do this week, and leaving debug info on makes our binaries *huge*
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like hyper may have fixed our memory issue after all. I'd still
like to spend some time looking at heap dumps because I still think our
memory usage is higher than reasonable, but it's low priority and not
something I'm going to do this week, and leaving debug info on makes our
binaries huge