Remain on current page if navigating to reverse dependencies page fails #12080
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how to decode this 🤔 
|
|
oh boy... looks gnarly 😅 I can take a look once I have a quiet minute again :) |
|
my first thought would be that this might have to use https://github.com/rust-lang/crates.io/blob/main/tests/helpers/visit-ignoring-abort.js, but it's just an educated guess 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves one of the reports in #11834.
Widely depended-on crates can cause timeouts when loading the reverse dependencies page.
The reverse dependencies route is the only one (bar email verification, which makes sense) that sends you to the index page upon error.
This pull request updates the error handling logic to use the
catch-allredirect that other routes use, resulting in the user remaining on the current page they are on.