Replace ember-ajax with ember-fetch
#1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchak do the error messages change in any way after this? |
|
We tried switching to ember-fetch a while ago and had a problem-- i don't know enough about what we were doing then, what might be different now, and what the cause of that problem was to know whether this will still be a problem :-/ |
|
@carols10cents thanks for pointing it out. I will investigate and report! |
|
@Turbo87 it should not :) I will do a serie of manual tests and check. |
|
@tchak @tylerturdenpants I've rebased this on |
|
Awesome, thanks for the verification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will path the way to eventually remove jQuery :)