Skip running a job if the crate/version deleted #11500
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
reviewed
Jul 3, 2025
| )) | ||
| | Err(diesel::result::Error::NotFound) => { | ||
| warn!( | ||
| "Skipping rendering README for vesion {}: no version found", |
There was a problem hiding this comment.
Suggested change
| "Skipping rendering README for vesion {}: no version found", | |
| "Skipping rendering README for version {}: no version found", |
| .., | ||
| )) = res | ||
| { | ||
| warn!("Skipping update default version for crate for {crate_id}: no crate found",); |
There was a problem hiding this comment.
Suggested change
| warn!("Skipping update default version for crate for {crate_id}: no crate found",); | |
| warn!("Skipping update default version for crate for {crate_id}: no crate found"); |
| let publish_details = PublishDetails::for_version(version_id, &mut conn).await?; | ||
| let Some(publish_details) = PublishDetails::for_version(version_id, &mut conn).await? | ||
| else { | ||
| warn!("Skipping publish notifications for {version_id}: no version found",); |
There was a problem hiding this comment.
Suggested change
| warn!("Skipping publish notifications for {version_id}: no version found",); | |
| warn!("Skipping publish notifications for {version_id}: no version found"); |
Turbo87
added
C-internal 🔧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11348.
After diffing in I found only 3 jobs that can fail because of deleted data. The rest should be fine.