trustpub: Disallow config creation if email is not verified #11351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
Turbo87
force-pushed
the
trustpub-verification
branch
from
0481586 to
c2c8048
Compare
eth3lbert
approved these changes
Jun 12, 2025
| @@ -61,8 +61,14 @@ pub async fn create_trustpub_github_config( | |||
| .load::<(i32, String, String, bool)>(&mut conn) | |||
| .await?; | |||
|
|
|||
| if !user_owners.iter().any(|owner| owner.0 == auth_user.id) { | |||
| return Err(bad_request("You are not an owner of this crate")); | |||
| let auth_owner = user_owners | |||
There was a problem hiding this comment.
Nit: Instead of auth_owner.3 It might be more readable to destructure it as a variable.
Suggested change
| let auth_owner = user_owners | |
| let (.., verified) = user_owners |
or
Suggested change
| let auth_owner = user_owners | |
| let (_, _, _, verified) = user_owners |
There was a problem hiding this comment.
that's a good idea. thanks! :)
Turbo87
force-pushed
the
trustpub-verification
branch
from
c2c8048 to
f10211e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #11294 (comment)