Skip to content

Add DELETE /api/v1/trusted_publishing/github_configs/{id} API endpoint #11209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented May 20, 2025

This PR implements another item on the todo list in #10247: an API endpoint to delete Trusted Publishing configurations for GitHub Actions.

The implementation should be relatively straight-forward. It checks that the authenticated users is an owner of the crate, and if the configuration exists, it deletes it and sends a notification email to all the owners.

Related:

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend ⚙️ labels May 20, 2025
@Turbo87 Turbo87 requested a review from a team May 20, 2025 12:26
Copy link
Contributor

@eth3lbert eth3lbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that blank line, the implementation looks solid to me, and it seems all the forbidden cases I'm aware of are already covered in the tests!
Nice work, thanks!

@Turbo87 Turbo87 force-pushed the delete-trustpub-config branch from 46cdfc0 to ea41253 Compare May 23, 2025 06:44
@Turbo87 Turbo87 force-pushed the delete-trustpub-config branch from ea41253 to 1788814 Compare May 23, 2025 07:19
@Turbo87 Turbo87 enabled auto-merge (squash) May 23, 2025 07:19
@Turbo87 Turbo87 merged commit f32470a into rust-lang:main May 23, 2025
10 checks passed
@Turbo87 Turbo87 deleted the delete-trustpub-config branch May 23, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants