Decline owner invites #1085
Merged
Decline owner invites #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tements in a diesel transaction
…d invited_user_id
former version used two separate routes for accept and decline, now use one route but have boolean value sent back indicating if invite was accepted or declined
…and error messages on crate by crate basis
…es of the crate_id, want crate_id for corresponding user_id
carols10cents
approved these changes
Sep 25, 2017
| crate_owner_invitation: InvitationResponse, | ||
| } | ||
| Ok(req.json(&R { crate_owner_invitation: crate_invite })) | ||
| decline_invite(req, conn, crate_invite) |
Member
There was a problem hiding this comment.
I really like how this ended up, the code's easier to read and well organized! 💯
Member
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Sep 25, 2017
1085: Decline owner invites r=carols10cents This implements deployable chunk 3: declining invitations of issue #924. The api route for declining an invite is the same as for accepting an invite. To know that an invite is being declined instead of accepted, the `accepted` field passed to the backend is set to `false`. If declined, the invite should be replaced with a message to the user confirming that they declined the invitation for the crate.
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements deployable chunk 3: declining invitations of issue #924. The api route for declining an invite is the same as for accepting an invite. To know that an invite is being declined instead of accepted, the
acceptedfield passed to the backend is set tofalse. If declined, the invite should be replaced with a message to the user confirming that they declined the invitation for the crate.