Turn long-deprecated -C options into errors

[RalfJung]

Proposal

We have some -C flags that have had no effect other than issuing a warning for a while:

• -Car has been documented to do nothing for more than 8 years (rust-lang/rust@691ab6c) and causes a warning for more than a year (mark deprecated option as deprecated in rustc_session to remove copypasta and small refactor rust#135126).
• -Cno-stack-check has been made a NOP and deprecated with a warning more than 9 years ago (rust-lang/rust@c670293)
• -Cinline-threshold has been made a NOP and deprecated with a warning almost 2 years ago (Deprecate no-op codegen option -Cinline-threshold=... rust#124712).

I think there's no reason to keep these around -- and it risks people using them without reading the docs properly and then getting unexpected results. So I propose we turn these warning into errors: rust-lang/rust#154498.

Mentors or Reviewers

If you have a reviewer or mentor in mind for this work, mention them here. You can put your own name here if you are planning to mentor the work.

Process

The main points of the Major Change Process are as follows:

• File an issue describing the proposal.
• A compiler team member who is knowledgeable in the area can second by writing @rustbot second or kickoff a team FCP with @rfcbot fcp $RESOLUTION.
  • Refer to Proposals, Approvals and Stabilization docs for when a second is sufficient, or when a full team FCP is required.
• Once an MCP is seconded, the Final Comment Period begins.
  • Final Comment Period lasts for 10 days after all outstanding concerns are solved.
  • Outstanding concerns will block the Final Comment Period from finishing. Once all concerns are resolved, the 10 day countdown is restarted.
  • If no concerns are raised after 10 days since the resolution of the last outstanding concern, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

[rustbot]

Important

This issue is not meant to be used for technical discussion. There is a Zulip stream for that.
Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections can formally be registered here by adding a comment.

@rustbot concern reason-for-concern
<description of the concern>

Concerns can be lifted with:

@rustbot resolve reason-for-concern

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler

[oli-obk]

@rfcbot fcp merge compiler

[rust-rfcbot]

Team member @oli-obk has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Mark-Simulacrum
• @SparrowLii
• @TaKO8Ki
• @cjgillot
• @davidtwco
• @estebank
• @jieyouxu
• @matthewjasper
• @nagisa
• @oli-obk
• @petrochenkov
• @spastorino
• @wesleywiser

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[RalfJung]

@SparrowLii @TaKO8Ki @davidtwco @estebank @spastorino @wesleywiser friendly FCP reminder :)

[rust-rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔