Skip to content

Also accept true and false on boolean flags #577

Closed
@Noratrieb

Description

@Noratrieb

Proposal

rustc currently accepts y, yes, on and n, no, off as arguments for boolean flags (stable ones like -Crpath and unstable ones like -Zbox-noalias).
This proposes to also accept true (meaning yes) and false (meaning no). trueand false are a natural way of expressing booleans and people sometimes make the mistake of using true or false only to then be rejected.
As we have three ways to describe them already, adding a fourth one shouldn't hurt anything (although it can be argued that three are enough).

Mentors or Reviewers

This is trivial to implement, I can do it myself

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was accepted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions