Skip to content

Rework rustc_serialize #329

Closed
Closed
@matthewjasper

Description

@matthewjasper

Proposal

rust-lang/rust#73851 reworks specialization in the following noticeable ways:

  • The type parameter in the Encodable and Decodable traits is moved from the method to the trait.
  • These traits are now derived using macros in rustc_macros rather than the built-in RustcEncodable and RustcDecodable derives.
  • Specialized implementations of Encodable and Decodable now directly use specialization.
  • A lot of transmutes are removed

Further documentation of serialization in rustc after the PR has landed can be found at rust-lang/rustc-dev-guide#785.

Mentors or Reviewers

PR has already been reviewed by @oli-obk

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-compilerAdd this label so rfcbot knows to poll the compiler teammajor-changeA proposal to make a major change to rustcmajor-change-acceptedA major change proposal that was accepted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions