fix division on SPARC #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Is the CI broken? |
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! I'm trying to fix CI in #394
src/int/udiv.rs
Outdated
| #[win64_128bit_abi_hack] | ||
| /// Returns `n / d` | ||
| pub extern "C" fn __udivti3(n: u128, d: u128) -> u128 { | ||
| u128_divide_sparc(n, d, &mut 0) |
Member
There was a problem hiding this comment.
Could this #[cfg] happen inside the previous intrinsics! block to avoid duplicating the definition?
Contributor
Author
There was a problem hiding this comment.
I changed it to use #[cfg] inside the previous block, but I don't know if it is beneficial because of all the duplicated #[cfg] that is required to completely disable u128_div_rem
src/int/specialized_div_rem/mod.rs
Outdated
| target_arch = "sparc64", | ||
| target_arch = "riscv32", | ||
| target_arch = "riscv64" | ||
| )))] |
Member
There was a problem hiding this comment.
Instead of conditional definitions of this constant could it use || and cfg!?
AaronKutch
force-pushed
the
sparc-division
branch
from
9481c53 to
78ea036
Compare
Member
|
👍 |
AaronKutch
added a commit
to AaronKutch/compiler-builtins
that referenced
this pull request
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #390. I decided to make an entire configuration path for all SPARC architectures, because SPARC does not have any widening multiplications which makes
_delegateinsanely slow. I manually tested the newu128_divide_sparcfunction, but plan on testing it later with the new test system in PR #384. This PR needs to be merged first because 32-bit SPARC will not build without this. I will rebase #384 afterwards to testu128_divide_sparcproperly.