Fix ios cross compilation #197
Conversation
|
@FlorianDenis would you be able to resolve conflicts for this? I think this looks good otherwise, but @madsmtm could you confirm? |
| @@ -661,7 +661,7 @@ impl Config { | |||
| panic!("unsupported msvc target: {}", target); | |||
| } | |||
| } | |||
| } else if target.contains("darwin") { | |||
| } else if target.contains("darwin") || target.contains("ios") { | |||
There was a problem hiding this comment.
Maybe:
| } else if target.contains("darwin") || target.contains("ios") { | |
| } else if target.contains("apple") { |
To better support tvOS, watchOS and visionOS?
| @@ -671,6 +671,14 @@ impl Config { | |||
| panic!("unsupported darwin target: {}", target); | |||
There was a problem hiding this comment.
This would need to be updated to support the other architectures used on Apple platforms, namely i686, arm64e, i386, armv7s, armv7k and arm64_32 (all of which should be passed with the same name to CMake).
|
You are asking for conflict resolution on a 10 line PR that got ignored for 8 months? |
|
This crate had a lapse in maintenance as you noticed, really the only thing we can do at this point is attempt to get it merged now. If you are uninterested in continuing then I (or perhaps @madsmtm) can pick up your work and reapply it. |
|
Feel free to pick up the work and try to get it merged 👍 |
CMAKE_OSX_ARCHITECTURESgets defined for iOS if not user-supplied (extending existing logic for macOS)CMAKE_OSX_SYSROOTgets defined as well