fix: Fix retrieval of AsyncFnOnce::Output
#829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't just assume it's always the second associated type of `AsyncFnOnce`.
|
I don't see why not but also chalk doesn't seem like it's going to be used by salsa for very much longer... 🤔 |
Because that could change (in fact it probably did change since this code was written, since now the
Yes, I'm doing that in fear that we might have bugs until then (but I don't know of any). |
|
whoops typo, *rust-analyzer not salsa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't just assume it's always the second associated type of
AsyncFnOnce.