Generalize with variance #673
Conversation
jackh726
force-pushed
the
generalize-variance
branch
from
873e3f7 to
9e0da9e
Compare
| @@ -660,7 +740,9 @@ impl<'t, I: Interner> Unifier<'t, I> { | |||
| if matches!(kind, TyVariableKind::Integer | TyVariableKind::Float) { | |||
| ty.clone() | |||
| } else if let Some(ty) = self.table.normalize_ty_shallow(interner, ty) { | |||
| self.generalize_ty(&ty, universe_index) | |||
| self.generalize_ty(&ty, universe_index, variance) | |||
| } else if matches!(variance, Variance::Invariant) { | |||
There was a problem hiding this comment.
The rustc code here also checks that this variable can name universe_index here, although that's maybe only for error messages.
There was a problem hiding this comment.
Hmm. So should I change this here?
There was a problem hiding this comment.
I think that we can keep the simpler code for now.
|
@bors r+ |
|
📌 Commit 9bf2ba0 has been approved by |
|
☀️ Test successful - checks-actions |
|
If it's not too much of a hassle, would it be possible to publish a new version to crates.io? There's one or two |
|
@lnicola just kicked off a publish |
|
Note to self: we should do |
Closes #667