Goals and folding goals #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous setup was over-designed and cumbersome to use, even if in some bizarre sense theoretically elegant. I apologize.
jackh726
approved these changes
Feb 7, 2020
Member
jackh726
left a comment
jackh726
left a comment
There was a problem hiding this comment.
Overall I like this; cleans up this quite a bit. That as_dyn is a bit ugly, but not sure there's a way around that.
|
|
||
| /// Folding a goal invokes the `fold_goal` callback (which will, by | ||
| /// default, invoke super-fold). | ||
| impl<TF: TypeFamily, TTF: TargetTypeFamily<TF>> Fold<TF, TTF> for Goal<TF> { |
Member
There was a problem hiding this comment.
Why remove this from boring_impls?
Contributor
Author
There was a problem hiding this comment.
It's not boring. It invokes a callback on folder rather than just recursively reproducing its structure.
Contributor
Author
There was a problem hiding this comment.
Maybe this naming scheme isn't obvious to everyone else though. :)
Member
There was a problem hiding this comment.
Yeah, my thought for "boring" is either boilerplate-like code or code that is extremely simple.
jackh726
reviewed
Feb 7, 2020
Contributor
Author
|
OK, @jackh726, I think I addressed all your comments. |
Member
|
Yeah, LGTM |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors how the Folder is setup:
The motivation for this work is to work towards the "syntactic equality" goal, where we desugar aliases into a combination of an inference variable and an alias goal ahead of time, rather than building "rich type equality" into the solver itself.