Split off ContextOps from Context #129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove it as a super trait, leaving ContextOps as a completely separate trait.
The motivation is that in rustc the
ChalkContext
which implsContextOps
carries an actualTyCtx<'a, 'tcx, 'gcx>
and needs the extra'a
lifetime parameter. However types that take justContext
need at most'tcx
and'gcx
, so to prevent the extra lifetime from leaking everywhereContextOps
is no longer a super trait ofContext
.