Skip to content

Split off ContextOps from Context #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2018

Conversation

leoyvens
Copy link
Contributor

Remove it as a super trait, leaving ContextOps as a completely separate trait.

The motivation is that in rustc the ChalkContext which impls ContextOps carries an actual TyCtx<'a, 'tcx, 'gcx> and needs the extra 'a lifetime parameter. However types that take just Context need at most 'tcx and 'gcx, so to prevent the extra lifetime from leaking everywhere ContextOps is no longer a super trait of Context.

@nikomatsakis nikomatsakis merged commit 3c3caae into rust-lang:master May 19, 2018
@nikomatsakis
Copy link
Contributor

Thanks @leodasvacas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants