Remove gh-pages deployment #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
- Prefer to specify a tag - Fix a step name on test Signed-off-by: Yuki Okushi <jtitor@2k36.org>
|
Do we care about gh-pages deployment given that docs.rs exists now (I suspect that code predates docs.rs)? We could also remove it. |
|
If we prefer to remove it instead, I'm happy to! I thought Alex deployed it intentionally and didn't want to break it :) |
|
I think it's just old. Back in the day you had to do this to host your docs since docs.rs didn't exist. It's not that bad if we have a reason for it, but I think I'd rather us remove it if there's no benefit (which seems to be the case). Maybe we should wait a day or so and see if anybody weighs in about it. |
|
I made a zulip discussion for it: https://rust-lang.zulipchat.com/#narrow/stream/351149-t-libs.2Fcrates/topic/cfg-if.20docs.20publishing |
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
thomcc
approved these changes
Oct 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems branch renaming disables gh-pages deployment:
cfg-if/.github/workflows/main.yml
Line 56 in 53939df
This makes it work again with some tweaks.
Note
Someone that has admin access to the repo has to enable below on the repo settings:
