Skip to content

CI: Run test on aarch64-apple-darwin #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2024
Merged

CI: Run test on aarch64-apple-darwin #947

merged 1 commit into from
Feb 15, 2024

Conversation

NobodyXu
Copy link
Collaborator

Also uses Swatinem/rust-cache@v2 to speedup compilation of dependencies.

@NobodyXu
CI: Run test on aarch64-apple-darwin
1799dc1 
Also uses Swatinem/rust-cache@v2 to speedup compilation of dependencies.
BlackHoleFox
BlackHoleFox approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@BlackHoleFox BlackHoleFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swatinem/rust-cache seems widely used and well-maintained, but an actual cc maintainer should confirm what the dependency policy is. On that point though splitting the cache addition into its own commit would make it easier to see.

@NobodyXu NobodyXu merged commit 2dcfa14 into main Feb 15, 2024
@NobodyXu NobodyXu deleted the NobodyXu-patch-2 branch February 15, 2024 23:59
@NobodyXu
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu approved these changes

@Mark-Simulacrum Mark-Simulacrum Awaiting requested review from Mark-Simulacrum

+1 more reviewer

@BlackHoleFox BlackHoleFox BlackHoleFox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NobodyXu @Amanieu @BlackHoleFox