Skip to content

Fix --target cflag on FreeBSD when compiling against clang #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Fix --target cflag on FreeBSD when compiling against clang #785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdc3a37
Fix --target cflag on FreeBSD when compiling against clang
mqudsi Feb 1, 2023
0e9373f
fixup! Fix --target cflag on FreeBSD when compiling against clang
mqudsi Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1722,6 +1722,23 @@ impl Build {
} else if target.contains("aarch64") {
cmd.args.push("--target=aarch64-unknown-windows-gnu".into())
}
} else if target.ends_with("-freebsd") && self.get_host()?.eq(target) {
// clang <= 13 on FreeBSD doesn't support a target triple without at least
// the major os version number appended; e.g. use x86_64-unknown-freebsd13
// or x86_64-unknown-freebsd13.0 instead of x86_64-unknown-freebsd.
let stdout = std::process::Command::new("freebsd-version")
.output()
.map_err(|e| {
Error::new(
ErrorKind::ToolNotFound,
&format!("Error executing freebsd-version: {}", e),
)
})?
.stdout;
let stdout = String::from_utf8_lossy(&stdout);
let os_ver = stdout.split('-').next().unwrap();

cmd.push_cc_arg(format!("--target={}{}", target, os_ver).into());
} else {
cmd.push_cc_arg(format!("--target={}", target).into());
}
Expand Down