Apple: Remove redundant flags #1256
Merged
+56
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
refactor-apple-flags
branch
2 times, most recently
from
3b8d330 to
75f3ea1
Compare
Contributor
|
cc @BlackHoleFox can you take a look at this PR please? |
madsmtm
changed the title
Contributor
Author
|
I decided to go a different direction with the PR, have updated the title and description to reflect that. |
Non-functional change.
The architecture is specified for Clang with the --target option, and both -arch and -m32/-m64 are passed to GCC elsewhere (should probably be changed to -march, but that's a different issue).
It is redundant, the version is already specified in `-target`.
madsmtm
force-pushed
the
refactor-apple-flags
branch
from
77b23d7 to
f86048a
Compare
NobodyXu
requested changes
Nov 2, 2024
Contributor
NobodyXu
left a comment
NobodyXu
left a comment
There was a problem hiding this comment.
Thanks, there's a merge conflict and one review feedback.
NobodyXu
approved these changes
Nov 2, 2024
Contributor
NobodyXu
left a comment
NobodyXu
left a comment
There was a problem hiding this comment.
Thanks LGTM, I will cut a release and hopefully there's no regression.
Merged
Contributor
Suppose I'm 4 hours late but this looks fine to me 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang's
--targetargument is enough to specify the architecture, OS and deployment target, so let's remove the redundant-arch,-m32/-m64and-m*-version-minflags.The first commit is a non-functional refactor, the others do the actual removal. Proper GCC support is still broken, since we specify
-archand not-march, will fix that separately.Fixes #1030.