Add support for preview features #9401
Closed
+486
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an experimental implementation of a feature that adds _preview features_ to Cargo. A preview feature is one that is still considered unstable, but is available on stable/beta for testing behind a new flag, `--enable-preview` that requires you explicitly enumerate the features to enable. The core idea is that the Cargo team would specifically designate a small set (potentially zero at any given point in time) of features as "available for preview", subject to criteria that ensure that a preview period of a feature is both worthwile and won't cause undue breakage. A rough framework for how to think of these was proposed in https://internals.rust-lang.org/t/survey-of-high-impact-features/14536. This implementation exists mainly to get feedback on whether the approach taken here is reasonable from a code point-of-view. Before this feature lands (if it does), it would have to go through an RFC process. For the initial implementation, I have designated one unstable feature (`patch-in-config`) and one unstable option (`--out-dir`) as "preview". This choice was based on some of the internals discussion linked above, but is in no way final.
|
r? @Eh2406 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #9457) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm going to go ahead and close this given the closure of rust-lang/rfcs#3120. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental implementation of a feature that adds preview
features to Cargo. A preview feature is one that is still considered
unstable, but is available on stable/beta for testing behind a new flag,
--enable-previewthat requires you explicitly enumerate the featuresto enable.
The core idea is that the Cargo team would specifically designate
a small set (potentially zero at any given point in time) of features as
"available for preview", subject to criteria that ensure that a preview
period of a feature is both worthwile and won't cause undue breakage. A
rough framework for how to think of these was proposed in
https://internals.rust-lang.org/t/survey-of-high-impact-features/14536.
This implementation exists mainly to get feedback on whether the
approach taken here is reasonable from a code point-of-view. Before this
feature lands (if it does), it would have to go through an RFC process.
For the initial implementation, I have designated one unstable feature
(
patch-in-config) and one unstable option (--out-dir) as "preview".This choice was based on some of the internals discussion linked above,
but is in no way final.