Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links vars showing up for testing packages #9065

Merged
merged 1 commit into from
Jan 12, 2021

Commits on Jan 12, 2021

  1. Fix links vars showing up for testing packages

    If a package is tested and the library for the package wasn't built
    (e.g. only tested or it wasn't present) then the `links` env vars from
    dependencies weren't showing up to the build script by accident. This
    was an accidental regression from rust-lang#8969.
    
    The intention of rust-lang#8969 was to exclude connections to build scripts
    connected via dev-dependencies, but it only applied a heuristic because
    the unit graph doesn't retain information about dev-dependencies. The
    fix here is to instead actually retain information about
    dev-dependencies which is only used for constructing the unit graph and
    connecting build script executions to one another.
    
    Closes rust-lang#9063
    alexcrichton committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    21a5efb View commit details
    Browse the repository at this point in the history