Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop current_exe pop hack in favor of CARGO_TARGET_DIR #8711

Closed
wants to merge 1 commit into from

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Sep 18, 2020

Depends on #8710 being included into the cargo with which the test suite is built. (I'm not sure exactly how this happens but I am guessing it would be after the next rustc release is out.)

Tested with:

$ cargo build --release
$ target/release/cargo test

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2020
@dtolnay
Copy link
Member Author

dtolnay commented Sep 18, 2020

Closing until #8710 is available; we can reopen when mergeable.

@dtolnay dtolnay closed this Sep 18, 2020
@dtolnay dtolnay deleted the globalroot branch September 18, 2020 02:18
@dtolnay dtolnay restored the globalroot branch September 18, 2020 02:18
@dtolnay dtolnay deleted the globalroot branch September 19, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants